This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
fetchFromGitLab: force re-fetch when rev changes #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd be inclined to rework both, and use what exists now as a base for a generic |
bbjubjub2494
force-pushed
the
fetchfromgitlab
branch
from
afb8fbb
to
372654c
Compare
bbjubjub2494
changed the title
|
I tried working on the refactor in a branch, but I am not comfortable writing such code for production because there seem to be too many small details in the original code like complex passthroughs and unsafe functions that I don't know the purpose of. I would suggest we do the minimal diff thing for now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few instances of
fetchFromGitLabin the repo, for instancegtk-doc.src.My primary goal when writing this was changing the output derivation following #11. This is doable with a lot less diff in
fetchFromGitLab, but it's worth asking whether both fetchers should be different and why. I think a lot of the divergence comes from years of random commits rather than from design.